Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a possibiliy of getting some wekan metrics datas #4700

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Added a possibiliy of getting some wekan metrics datas #4700

merged 2 commits into from
Sep 22, 2022

Conversation

Emile840
Copy link
Contributor

Route "/metrics" will be used to get those datas and "WEKAN_METRICS_ACCEPTED_IP_ADRESS" environment variable must be settled with a comma separated list of trusted ip address

@mfilser
Copy link
Contributor

mfilser commented Sep 21, 2022

@Emile840
Just for information: It seems you have an auto-formatter in your IDE which changed a lot of code, in my point of view it could result in merge conflicts, especially for every other developer who wants to merge their changes to the current master branch.
Here's the file with a lot of unnecessary code changes in this commit:
models/users.js

@Emile840
Copy link
Contributor Author

@mfilser
You're right, i'll desactive it while working on wekan.

@xet7 xet7 merged commit e2c241f into wekan:master Sep 22, 2022
xet7 added a commit that referenced this pull request Sep 22, 2022
@xet7
Added METRICS_ALLOWED_IP_ADDRESSES settings to Docker/Snap/Source htt…
3486281 
…ps://github.com/wekan/wekan/wiki/Metrics .

Thanks to xet7 !

Related #4700
xet7 added a commit that referenced this pull request Oct 23, 2022
@xet7
Fix to use metrics related code only when enabled, because got error …
d474ce6 
…about userId.

Thanks to xet7 !

Related #4728,
related #4700
xet7 added a commit that referenced this pull request Oct 23, 2022
@xet7
Fix metrics to check that socket is defined, because got error about …
a9dfcf8 
…userId.

Thanks to xet7 !

Related #4728,
related #4700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Emile840 @mfilser @xet7