Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added archive option to of Wekan API #5265

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

gustavengstrom
Copy link
Contributor

This adds the a new boolean param option archive to edit_card of the Wekan API.

Note: the API docs also need an update which is not included in this commit.

@xet7
Copy link
Member

xet7 commented Jan 15, 2024

@gustavengstrom

That existing API returns card count.

But your changes look like, that you change all archived cards to not archived, an not archived cards to archived. That does not make any sense.

@xet7 xet7 closed this Jan 15, 2024
@gustavengstrom
Copy link
Contributor Author

@xet7 I am not sure I understand. My code changes are under @operation edit_card on line 3449.

I have tested the edit_card API call using:

requests.put(f'http://localhost:4001/api/boards/{board}/lists/{list}/cards/{card}', headers = headers, data={"archive": True}).json()

which works perfectly both for archiving and unarchiving a single card. The other cards of the board were not affected by this !

You seem to be referring to @operation get_list_cards_count which is in line 3409 above. I haven´t made any changes to this function.

@xet7 xet7 reopened this Jan 15, 2024
@xet7
Copy link
Member

xet7 commented Jan 15, 2024

@gustavengstrom

Sorry, I'll try to look and test it more carefully in near future. Thanks!

@xet7 xet7 merged commit e15611a into wekan:main Jan 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants