WELD-1795 Add builder for custom beans #17
Conversation
| * @return self | ||
| */ | ||
| BeanBuilder<T> read(AnnotatedType<T> type); | ||
|
|
There was a problem hiding this comment.
what about read(BeanAttributes) version?
There was a problem hiding this comment.
It could enable some more usecases. For example we have BeanManager.createBeanAttributes(AnnotatedMember<?> type) that could be used to load BeanAttributes which are then altered in bean builder
| * @param callback | ||
| * @return self | ||
| */ | ||
| BeanBuilder<T> disposeWith(Consumer<T> callback); |
There was a problem hiding this comment.
Won't destroyWith vs disposeWith naming be confusing? Won't people be thinking that they need to provide both? Using an overloaded method would IMHO make it more straightforward.
There was a problem hiding this comment.
The idea was to follow the naming of createWith()/produceWith(). createWith()/destroyWith() should correspond to Contextual.create()/destroy(), whereas produceWith() callbacks are special constructs similar to producers.
There was a problem hiding this comment.
OK, let's leave it this way for now.
No description provided.