WELD-2064 with configurable parameter and an automated test #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LD-2064 Conflicts: impl/src/main/java/org/jboss/weld/bootstrap/BeanDeployment.java
manovotn
force-pushed
the
weld2064_master
branch
3 times, most recently
from
e7548cf
to
04c37c7
Compare
|
Added a doc section to 'Weld Configuration' . |
manovotn
force-pushed
the
weld2064_master
branch
from
04c37c7
to
05923c4
Compare
|
Removed |
manovotn
force-pushed
the
weld2064_master
branch
from
05923c4
to
f24e247
Compare
|
This is looking great! I am wondering when this will be merged, |
|
Closed in favor of #1366 (all commits included) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of Lenny's original commit.
Introduces a configurable property allowing to set a delimiter for a bean archive ID.
I am still trying to figure out the bootstrapping part in WeldStartup.
Also there is an automated test added which I believe could do the right thing.
In the current form, the tests-arquillian as well as unit tests in core impl pass, though I am unsure it is a correct solution.
Furthermore the names of the properties and the helper class are a subject for discussion :)