WELD-2225 stick to new CDI 2.0-EDR2 SE API. #1463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Object[] constructorParams = new Object[] {}; | ||
| for (Class<? extends Extension> extensionClass : extensionClasses) { | ||
| try { | ||
| Extension extension = extensionClass.getDeclaredConstructor(new Class[] {}).newInstance(constructorParams); |
There was a problem hiding this comment.
Please use org.jboss.weld.environment.se.SecurityActions.newInstance(Class<T>) instead..
tremes
force-pushed
the
WELD-2225
branch
2 times, most recently
from
390a2c7
to
e0f6e32
Compare
|
|
||
| @Override | ||
| public Weld addExtensions(Class<? extends Extension>... extensionClasses) { | ||
| Object[] constructorParams = new Object[] {}; |
There was a problem hiding this comment.
This variable is useless in most cases. I would rather pass new Object[] {} to log method directly.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.