WELD-2408 Beans.xml with only comment will be treated as an empty bea…

[manovotn]

…ns.xml

Technically speaking, XML containing only comments is invalid (according to w3c scheme which we use) but so is empty XML file and CDI spec requires empty file to work.
The question is then, what does empty mean? No chars at all, or no meaningful elements?

I just played around with what we could do to make this work, not sure we should do it at all. Opinions are welcome.

[rdebusscher]

I agree that a file containing only a comment is strictly speaking not valid.

But since an empty file is supported, it seems logical to me that comments are ignored to determine if the file is empty or not (just like comments are ignored by the Java compiler)

[tremes]

I am not sure whether this can have some significant negative performance implications (hopefully not), but otherwise it looks OK.

[manovotn]

The loop breaks as soon as we find any non-comment tag. The only real overhead is opening the input stream twice. Shouldn't be that much unless you plan to write a novel in a form of a beans.xml comment.

[mkouba]

I tend to disagree with this solution. An empty file is just a marker. Once you add a content it must be parsed and so I think it's not a problem when it fails for an invalid xml file. Using <!-- empty beans xml --> <beans/> is the way to go.

[mkouba]

WELD-2408 was rejected.