Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WELD-2507 Abstract package private class not intercepted correctly. #1853

Merged
merged 4 commits into from Jul 24, 2018

Conversation

manovotn
Copy link
Contributor

No description provided.

@manovotn manovotn requested review from mkouba and nziakova June 29, 2018 10:24
@manovotn
Copy link
Contributor Author

I am happy to answer any questions related to this. Or maybe you can think of better solution/more tests that should be covered?

manovotn and others added 3 commits July 13, 2018 16:05
- match the whole method signature
- better handling of class hierarchies
- improved test
@manovotn
Copy link
Contributor Author

Hmm, so just like I expected, my previous '30 min fix' didn't quite cover complex hierarchies.
The tests looks robust enough now, should cover even weirder cases than the originally reported one :)
Thanks for improving the PR!

@manovotn manovotn merged commit 499e1b2 into weld:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants