Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WELD-2623 Update arq-weld-container, re-enable testing in embedded co… #1984

Merged
merged 2 commits into from Apr 29, 2020

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Apr 29, 2020

…ntainer.

This PR also tests updated CI jobs - those should now (for master branch) be executing all tests that don't need EE container or servlet.

@manovotn
Copy link
Contributor Author

On weld-probe-core, Spotbugs was giving the following error:

[INFO] --- spotbugs-maven-plugin:3.1.10:check (default) @ weld-probe-core ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
[INFO] Total bugs: 2
[ERROR] Method org.jboss.weld.probe.Resource$Handler.setCorsHeaders(HttpServletResponse) seems to be useless [org.jboss.weld.probe.Resource$Handler] At Resource.java:[line 455] UC_USELESS_VOID_METHOD
[ERROR] Method org.jboss.weld.probe.Resource$Handler.setHeaders(HttpServletResponse, String) seems to be useless [org.jboss.weld.probe.Resource$Handler] At Resource.java:[line 448] UC_USELESS_VOID_METHOD

This is awkward as that source file is exactly the same (minus package changes) on current 3.1 branch where Spotbugs passes without complaining. Didn't manage to see why and the method is used and is definitely not "empty" or "useless" as it suggests.

@manovotn
Copy link
Contributor Author

retest this please

@manovotn manovotn merged commit bf4fb9d into weld:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant