Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WELD-2674] NPE when deploying an EJB bean in default package #2380

Merged
merged 1 commit into from Jun 3, 2021
Merged

[WELD-2674] NPE when deploying an EJB bean in default package #2380

merged 1 commit into from Jun 3, 2021

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Jun 2, 2021

@spyrkob spyrkob mentioned this pull request Jun 2, 2021
Merged
manovotn
manovotn requested changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, otherwise this looks good.

impl/src/main/java/org/jboss/weld/util/Proxies.java Outdated Show resolved Hide resolved
manovotn
manovotn approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for contributing!
I'll merge it once CI run passes.

@manovotn manovotn merged commit 3cfad77 into weld:master Jun 3, 2021
@manovotn
Copy link
Contributor

manovotn commented Jun 3, 2021

@spyrkob thanks for contributing the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@spyrkob @manovotn