Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WELD-1261 Tests marked as broken/ignored, which now work on AS and refer... #251

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,13 @@ public class WeldClassTest {

private final ClassTransformer transformer = new ClassTransformer(new TypeStore());

/*
* description = "WELD-216"
*/
@Test
@Ignore // Broken
public void testMemberClassWithGenericTypes() {
AnnotatedType<?> at = WeldClassImpl.of(new Kangaroo().procreate().getClass(), transformer);
WeldClassImpl.of(at, transformer);
}

/*
* description = "WELD-216"
*/
@Test
@Ignore
/*
* Not isolated, depends on someone else initializing Containers.
*
Expand All @@ -63,12 +55,8 @@ public void testLocalClassWithGenericTypes() {
AnnotatedType<?> at = WeldClassImpl.of(new Koala().procreate().getClass(), transformer);
WeldClassImpl.of(at, transformer);
}

/*
* description = "WELD-216"
*/

@Test
@Ignore
/*
* Not isolated, depends on someone else initializing Containers.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,7 @@ public static WebArchive createDeployment() {
.addAsWebResource(ErrorPageTest.class.getPackage(), "storm.jsf", "storm.jspx")
.addAsWebInfResource(EmptyAsset.INSTANCE, "beans.xml");
}

/*
* description = "WELD-29"
*/
@Category(Broken.class)

@Test
public void testActionMethodExceptionDoesNotDestroyContext() throws Exception {
WebClient client = new WebClient();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ public void testBlogConsumed() {
* Even though this is not very useful it should still be possible.
*/
@Test
@Category(Broken.class)
// WELD-406
public void testTwoBeansExactlyTheSame() {
Assert.assertEquals(2, beanManager.getBeans(UselessBean.class).size());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public void testInterceptionWorksOnClassWithFinalMethod() {
/*
* description = "WELD-771"
*/
@Category(Broken.class)
@Test
public void testFinalMethodInvocationOnInterceptedBean() {
briefing.performBriefing();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ public static Archive<?> deploy() {
/*
* description = "WELD-568"
*/
@Category(Broken.class)
@Test
public void testWeldClassForGenericSuperclass() {
WeldClass<StringProcessor> weldClass = WeldClassImpl.of(StringProcessor.class, new ClassTransformer(new TypeStore()));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public static Archive<?> deploy() {
}

@Test
@Category(Broken.class) // TODO -- fix this for AS7.1
@Category(Broken.class) // WELD-1244
public void testRetry(Processor processor) {
FailingProcessor.intercepts = 0;
RetryInterceptor.invocationCount = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public static Archive<?> deploy() {
ShrinkWrap.create(JavaArchive.class)
.addPackage(EnterpriseBeanProxyTest.class.getPackage())
.addAsManifestResource(EmptyAsset.INSTANCE, "beans.xml")
.addClass(Utils.class)
);
}

Expand All @@ -47,9 +48,8 @@ public static Archive<?> deploy() {
*
* <a href="https://jira.jboss.org/jira/browse/WBRI-109">WBRI-109</a>
*/
// Broken due to WELDINT-45
// WELDINT-45
@Test
@Category(Broken.class)
public void testNoInterfaceView(Mouse mouse) throws Exception {
Assert.assertTrue(Utils.isProxy(mouse));
Assert.assertTrue(mouse instanceof Mouse);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public static Archive<?> deploy() {
private BeanManagerImpl beanManager;

@Test
@Category(Broken.class)
public void testReferencesEqual() {
Sheep sheep = Utils.getReference(beanManager, Sheep.class);
sheep.setAge(10);
Expand Down

This file was deleted.