Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WELD-2690 Replace usages of getParameterTypes().length with getParame… #2560

Merged
merged 1 commit into from
Nov 9, 2021
Merged

WELD-2690 Replace usages of getParameterTypes().length with getParame… #2560

merged 1 commit into from
Nov 9, 2021

Conversation

clara0
Copy link
Contributor

@clara0 clara0 commented Nov 7, 2021

@manovotn
Copy link
Contributor

manovotn commented Nov 9, 2021

I see no reason not to accept this change. However, I wonder what is so devilish about getParameterTypes().length that it needs changing throughout Weld and whole WFLY @clara0? :-)

@manovotn manovotn merged commit 75c2a00 into weld:master Nov 9, 2021
@clara0
Copy link
Contributor Author

clara0 commented Nov 9, 2021

Hi @manovotn, getParameterTypes().length ends up creating unnecessary clones, which take up memory and adds to the burden of the GC. Furthermore, replacing it with getParameterCount() increases the readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@clara0 @manovotn