WELD-2744 CFW update and needed changes to keep operating correctly on JDK 17+ #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [jboss-classfilewriter](https://github.com/jbossas/jboss-classfilewriter) from 1.2.5.Final to 1.3.0.Final. - [Release notes](https://github.com/jbossas/jboss-classfilewriter/releases) - [Commits](jbossas/jboss-classfilewriter@1.2.5.Final...1.3.0.Final) --- updated-dependencies: - dependency-name: org.jboss.classfilewriter:jboss-classfilewriter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
manovotn
commented
Jun 7, 2023
manovotn
commented
Jun 7, 2023
impl/src/main/java/org/jboss/weld/bean/proxy/util/WeldDefaultProxyServices.java
Outdated
Show resolved
Hide resolved
manovotn
changed the title
mkouba
reviewed
Jun 7, 2023
impl/src/main/java/org/jboss/weld/bean/proxy/util/WeldDefaultProxyServices.java
Outdated
Show resolved
Hide resolved
…ting DefaultClassFactory.INSTANCE
|
All tests passes, going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFW in version 1.3.0.Final includes following commit - jbossas/jboss-classfilewriter@4028c25
This means as soon as
DefaultClassFactory.INSTANCEgets initialized, you need--add-opensto be able to execute the code in there - else you're getting an exception.Even though we never use CFW to define classes, this still affects us because of the way we instantiate
ClassFilein ourProxyFactory- we use a deprecated method that now gets re-routed to a default implementation of the class factory.In order to bypass this, we need to use a variant of the
ClassFilemethod where we specify CL as well asClassFactoryinstance. This PR uses dummy variant to do just that.