Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WELD-2756 Add support for InvocationContext.getInterceptorBindings() #2863

Merged
merged 2 commits into from
Oct 25, 2023
Merged

WELD-2756 Add support for InvocationContext.getInterceptorBindings() #2863

merged 2 commits into from
Oct 25, 2023

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jul 18, 2023

No description provided.

@Ladicek Ladicek force-pushed the invocation-context-interceptor-bindings branch from ffb3ed5 to e059f43 Compare September 1, 2023 13:51
@manovotn
Copy link
Contributor

manovotn commented Sep 20, 2023 •
edited
Loading

This PR requires Weld API release with weld/api#177.
The TCK upgrade doesn't seem mandatory as there are no TCK tests for this.
There is a pending TCK PR, jakartaee/cdi-tck#479. The next released version will therefore bring needed coverage which we should pass with no further changes beyond this PR.

Notes to self:

  • We should also look at any internal usage of our own now-deprecated APIs and see if we can just defer to the standard way instead
  • We also need to take a look at any doc references and correct them - probably keep relevant sections and mention that this is now standardized.

@manovotn manovotn force-pushed the invocation-context-interceptor-bindings branch from e059f43 to 0f72897 Compare September 20, 2023 14:52
@manovotn
Copy link
Contributor

Rebased, added deprecation notes to docs and tests, updated deps (no longer depends on SNAPSHOT of TCKs and need 6.x for Weld API).

@manovotn manovotn force-pushed the invocation-context-interceptor-bindings branch from 0f72897 to 3cf0aea Compare October 25, 2023 10:19
@manovotn manovotn marked this pull request as ready for review October 25, 2023 10:19
@manovotn manovotn self-requested a review as a code owner October 25, 2023 10:19
@manovotn manovotn changed the title Add support for InvocationContext.getInterceptorBindings() WELD-2756 Add support for InvocationContext.getInterceptorBindings() Oct 25, 2023
@manovotn
Copy link
Contributor

Rebased onto master, the CI should now pass just fine.

@manovotn manovotn mentioned this pull request Oct 25, 2023
Merged
manovotn
manovotn approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ladicek

@manovotn manovotn merged commit 884e436 into weld:master Oct 25, 2023
12 checks passed
@Ladicek Ladicek deleted the invocation-context-interceptor-bindings branch October 25, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Ladicek @manovotn