Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WELD-2768 support explicitly declaring @Priority on producers #2898

Merged
merged 1 commit into from Dec 5, 2023
Merged

WELD-2768 support explicitly declaring @Priority on producers #2898

merged 1 commit into from Dec 5, 2023

Conversation

manovotn
Copy link
Contributor

Weld implementation for jakartaee/cdi#556
Tests for this are on a TCK PR - jakartaee/cdi-tck#499 (and this PR passes them)
I don't mind adding tests here as well, but it would basically be a duplication of the same ones - WDYT @mkouba?

@manovotn manovotn requested a review from mkouba November 30, 2023 18:02
@manovotn manovotn force-pushed the weld2768 branch 2 times, most recently from ab065c5 to 42cc271 Compare December 1, 2023 11:02
mkouba
mkouba approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@manovotn
Copy link
Contributor Author

manovotn commented Dec 5, 2023

I've updated the PR, notably I:

  • Moved the processing of explicit priority into a protected method that subclasses need to invoke (because they also need to initialize their annotated references prior to this)
  • Added test coverage equal to what's in the TCKs in case TCK changes or excludes something in the future
  • Added extra testing for combination of locally enabled alternative (via beans.xml) declaring producers with explicit priority values

@manovotn manovotn merged commit 19076fe into weld:master Dec 5, 2023
12 checks passed
@manovotn manovotn deleted the weld2768 branch December 5, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@manovotn @mkouba