Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jetty6 support, migrate needed jetty6 bits to GWTHostedMode, upda... #309

Closed
wants to merge 1 commit into from

Conversation

jmcc0nn3ll
Copy link
Contributor

Jetty 6 was EOL'd in 2010 and there have been ~150 releases since then, so cleared out that support.

Also set the default support for Jetty to 7.2+, 8 and 9 since Jetty 7 and Jetty 8 are strictly in maintenance release mode locked in 7.6.x and 8.1.x respectively, and Jetty 9 is the current recommended stable release.

Tested this on 7.6.11, 8.1.11 and 9.0.3.

I documented setup for Jetty 9 (basically same for 7 and 8 as well) here: http://www.eclipse.org/jetty/documentation/current/framework-weld.html

@mkouba
Copy link
Member

mkouba commented Jun 7, 2013

Merged, thanks!

@mkouba mkouba closed this Jun 7, 2013
@mkouba
Copy link
Member

mkouba commented Jun 12, 2013

Actually the setup for Jetty 9 is a little bit outdated - jetty-web.xml and org.jboss.weld.environment.jetty.EclipseWeldServletHandler are no longer required. As of 7.2 Weld implements org.eclipse.jetty.servlet.ServletContextHandler.Decorator interface to inject servlets and filters. Listeners unfortunately don't work because they're already created at the time the decorator is registered.

@jmcc0nn3ll
Copy link
Contributor Author

I'll take a look this week and update, I am interested in what we can do to make it dead easy to setup, ideally just having the dependency show up in the server classes and things just work

@mkouba
Copy link
Member

mkouba commented Jun 12, 2013

Great! In fact jetty-env.xml is not required either (provided you configure BeanManagerResourceBindingListener). Maybe we could leverage web-fragment.xml to register these listeners automatically. See also related issue: https://issues.jboss.org/browse/WELD-985

@jmcc0nn3ll
Copy link
Contributor Author

ok, I have the servlet and filter working without the web and env descriptors...am poking around to see if I can do something about the listener not working.

thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants