WELD-1633 extend.xml documentation fixes #526
Conversation
|
Triggering build using a merge of b93a7a8 on branch master: |
| //if the class implements Service, make it an @Alternative | ||
|
|
||
| /* if the class implements Service, make it an @Alternative */ | ||
| if (!Service.class.isAssignableFrom(type.getJavaClass())) { |
There was a problem hiding this comment.
This check is redundant as this is guarded by the type variable upper bound.
|
Build 432 is now running using a merge of b93a7a8 on branch master: |
|
Build 432 outcome was SUCCESS using a merge of b93a7a8 on branch master: |
|
Triggering build using a merge of 450b2b3 on branch master: |
|
I have updated the pull request, removed the unecessary check in the ServiceAlternativeExtension and added one in the QualifiedNameExtension |
|
Build 436 is now running using a merge of 450b2b3 on branch master: |
|
Build 436 outcome was SUCCESS using a merge of 450b2b3 on branch master: |
| @@ -589,9 +649,12 @@ public class QualifiedNameExtension implements Extension { | |||
| @Override | |||
| public boolean isAnnotationPresent(Class<? extends Annotation> annType) { | |||
| if (Named.class.equals(annType)) { | |||
| return true; | |||
| Package pkg = at.getJavaClass().getPackage(); | |||
There was a problem hiding this comment.
I think that "if (Named.class.equals(annType))" then we can safely return true. Otherwise the PR looks good!
|
Triggering build using a merge of 273a211 on branch master: |
|
updated the pull request, reverted the QualifiedNameExtension::isAnnotationPresent change. |
|
Build 440 is now running using a merge of 273a211 on branch master: |
|
Merged, thanks! |
Fixing issues described in the WELD-1633 JIRA and further minor cleanups
uses /* comments */ consistently throughout the chapter instead of // (as the docbook template used doesn't seem to understand // as comments in the code listings