Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WELD-1726 Isolate Weld SE/Servlet logging into message logger interfaces #650

Closed
wants to merge 2 commits into from
Closed

WELD-1726 Isolate Weld SE/Servlet logging into message logger interfaces #650

wants to merge 2 commits into from

Conversation

hasys
Copy link
Contributor

@hasys hasys commented Sep 9, 2014

No description provided.

@weld-tester
Copy link

Can one of the admins verify this patch?

@hasys hasys force-pushed the servletandselogger branch 2 times, most recently from 31a2c21 to 54acf60 Compare September 9, 2014 16:06
@weld-tester
Copy link

Triggering build using a merge of 54acf60 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 46 is now running using a merge of 54acf60 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/46

@weld-tester
Copy link

Build 46 outcome was FAILURE using a merge of 54acf60 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/46
Public: https://hudson.jboss.org/hudson/job/Weld-2.x-pull-player-executor-osprey/46

jharting
jharting reviewed Sep 10, 2014
View reviewed changes
environments/se/core/src/main/java/org/jboss/weld/environment/se/Weld.java
@@ -220,6 +221,7 @@ protected Deployment createDeployment(ResourceLoader resourceLoader, CDI11Bootst
deployment= new WeldDeployment(resourceLoader, bootstrap, discoveredArchives, loadedExtensions);
CommonLogger.LOG.archiveIsolationEnabled();
}
WeldSELogger.LOG.multipleIsolation(isolation != null && Boolean.valueOf(isolation));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be here - it was replaced by CommonLogger.LOG.archiveIsolationEnabled() / CommonLogger.LOG.archiveIsolationDisabled()

@weld-tester
Copy link

Triggering build using a merge of 479ffe9 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 47 outcome was FAILURE using a merge of 479ffe9 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/47
Public: https://hudson.jboss.org/hudson/job/Weld-2.x-pull-player-executor-osprey/47

@weld-tester
Copy link

Triggering build using a merge of c0e2522 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 48 is now running using a merge of c0e2522 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/48

@weld-tester
Copy link

Build 48 outcome was SUCCESS using a merge of c0e2522 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/48
Public: https://hudson.jboss.org/hudson/job/Weld-2.x-pull-player-executor-osprey/48

@jharting
Copy link
Member

Merged, thanks!

@jharting jharting closed this Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hasys @weld-tester @jharting