WELD-1752 servlet api abstraction for javax.servlet.ServletRequest#isAsy... #674
Conversation
|
Triggering build using a merge of 20df0bb on branch 2.2: |
|
Build 85 outcome was FAILURE using a merge of 20df0bb on branch 2.2: |
|
Triggering build using a merge of 09b4474 on branch 2.2: |
|
Build 86 outcome was SUCCESS using a merge of 09b4474 on branch 2.2: |
|
|
||
| boolean isAsyncStarted; | ||
| try { | ||
| Method isAsyncStartedMethod = servletRequestClass.getMethod(IS_ASYNC_STARTED_METHOD_NAME); |
There was a problem hiding this comment.
Possible optimization - do not store a reference to Class but rather directly to the method. Then, you no longer need to call getMethod() on each access.
|
Build 86 outcome was SUCCESS using a merge of 09b4474 on branch 2.2: |
1 similar comment
|
Build 86 outcome was SUCCESS using a merge of 09b4474 on branch 2.2: |
|
Triggering build using a merge of ccb337e on branch 2.2: |
|
Build 91 outcome was SUCCESS using a merge of ccb337e on branch 2.2: |
|
|
||
| private final boolean asyncSupported; | ||
|
|
||
| private Method isAsyncStartedMethod; |
|
Triggering build using a merge of 9ecb70a on branch 2.2: |
|
Build 94 outcome was SUCCESS using a merge of 9ecb70a on branch 2.2: |
|
Merged, thanks! |
...ncStarted