Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WELD-1866 Probe - config property to skip monitoring of certain events #854

Closed
wants to merge 1 commit into from

Conversation

mkouba
Copy link
Member

@mkouba mkouba commented Feb 11, 2015

  • add timestamp to EventInfo

@weld-tester
Copy link

Triggering build using a merge of 1d901d1 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 482 is now running using a merge of 1d901d1 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/482

@weld-tester
Copy link

3 similar comments
@weld-tester
Copy link

@weld-tester
Copy link

@weld-tester
Copy link

@jharting
Copy link
Member

retest this please

@weld-tester
Copy link

Triggering build using a merge of 1d901d1 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 487 is now running using a merge of 1d901d1 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/487

@weld-tester
Copy link

data.data.forEach(function(event) {
event['tsShort'] = moment(event['ts']).format(
'HH:mm:ss');
event['tsLong'] = moment(event['ts']).format(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a user switch to tsLong format somehow? I am thinking that having .SSS even in the short version could be useful as many events could be fired within the same second.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsLong is a title of the span tag which contains tsShort value. But showing millis in the short form is a good idea.

@jharting
Copy link
Member

Merged with the time format changed. Thanks!

@jharting jharting closed this Feb 13, 2015
@weld-tester
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants