Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WELD-1917 AbstractCDI - cache Instance instance #937

Merged
merged 2 commits into from Apr 13, 2015
Merged

WELD-1917 AbstractCDI - cache Instance instance #937

merged 2 commits into from Apr 13, 2015

Conversation

mkouba
Copy link
Member

@mkouba mkouba commented Apr 10, 2015

  • make AbstractCDI.getInstance() protected

@weld-tester
Copy link

Triggering build using a merge of fe20c54 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@mkouba
Copy link
Member Author

mkouba commented Apr 10, 2015

Unfortunately, WildFly integration does not use SimpleCDI but AbstractCDI. We will have to cache Instance instance in AbstractCDI (i.e. this will be the default implementation).

@weld-tester
Copy link

Build 679 is now running using a merge of fe20c54 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/679

@weld-tester
Copy link

Build 679 outcome was FAILURE using a merge of fe20c54 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/679
Public: https://hudson.jboss.org/hudson/job/Weld-2.x-pull-player-executor-osprey/679

@mkouba mkouba changed the title WELD-1917 SimpleCDI - cache Instance instance WELD-1917 AbstractCDI - cache Instance instance Apr 10, 2015
@weld-tester
Copy link

Triggering build using a merge of 34fb06e on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 680 is now running using a merge of 34fb06e on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/680

@weld-tester
Copy link

Build 680 outcome was FAILURE using a merge of 34fb06e on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/680
Public: https://hudson.jboss.org/hudson/job/Weld-2.x-pull-player-executor-osprey/680

@weld-tester
Copy link

Triggering build using a merge of 5e6564f on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 683 is now running using a merge of 5e6564f on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/683

@weld-tester
Copy link

Build 683 outcome was SUCCESS using a merge of 5e6564f on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/683
Public: https://hudson.jboss.org/hudson/job/Weld-2.x-pull-player-executor-osprey/683

1 similar comment
@weld-tester
Copy link

Build 683 outcome was SUCCESS using a merge of 5e6564f on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/683
Public: https://hudson.jboss.org/hudson/job/Weld-2.x-pull-player-executor-osprey/683

@weld-tester
Copy link

Triggering build using a merge of 516d170 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 691 outcome was FAILURE using a merge of 516d170 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/691
Public: https://hudson.jboss.org/hudson/job/Weld-2.x-pull-player-executor-osprey/691

@mkouba
Copy link
Member Author

mkouba commented Apr 13, 2015

This needs rebase...

@mkouba
WELD-1917 AbstractCDI - cache Instance by default
17d5069 
- make AbstractCDI.getInstance() protected so that subclasses are able to override the default behavior
@mkouba
WELD-1917 Add simple test
25a9721
@weld-tester
Copy link

Triggering build using a merge of 25a9721 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/

@weld-tester
Copy link

Build 693 is now running using a merge of 25a9721 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/693

@weld-tester
Copy link

Build 693 outcome was SUCCESS using a merge of 25a9721 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor-osprey/693
Public: https://hudson.jboss.org/hudson/job/Weld-2.x-pull-player-executor-osprey/693

@jharting jharting merged commit 25a9721 into weld:master Apr 13, 2015
@jharting
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mkouba @weld-tester @jharting