Disable clippy because it regularly causes the builds to fail #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
disable_clippy
branch
from
174c96d
to
ad250d0
Compare
|
@bcl can you take a look at the second commit, it adds the build_id filed for the Groups table (so that depsolve works again, hopefully) and I've modified the code where I've found it to be realated but I'm still missing something b/c one of the tests fails. |
atodorov
force-pushed
the
disable_clippy
branch
from
0a8fcf9
to
0a7d821
Compare
and default to 0 when reading this column because it can be NULL
also initialize with 0 where we create some groups build id 0
NOTE: bdcs import didn't insert values for the groups.build_id field and I've inserted them manually. Probably the importer needs to be updated to fix this!
atodorov
force-pushed
the
disable_clippy
branch
from
0a7d821
to
0ccaad7
Compare
|
Changes Unknown when pulling 0ccaad7 on atodorov:disable_clippy into ** on weldr:master**. |
|
@bcl can you review this again b/c I've made more changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.