Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add groups and getGroupsLike tests #154

Closed
wants to merge 2 commits into from
Closed

Add groups and getGroupsLike tests #154

wants to merge 2 commits into from

Conversation

atodorov
Copy link
Member

@atodorov atodorov commented Apr 6, 2018

NOTE: this is based on #153

bcl and others added 2 commits April 4, 2018 15:01
@bcl
Add getGroupsLike
2233851 
This runs a SQL LIKE query on the groups table, returning entries that
match the query string. Use % as a wildcard, and _ to match an
individual character.
@atodorov
Add tests for groups and getGroupsLike
de20ff4
@atodorov atodorov requested a review from bcl April 6, 2018 14:12
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 84.976% when pulling de20ff4 on atodorov:add_getGroupsLike_tests into 720b252 on weldr:master.

@bcl
Copy link
Contributor

bcl commented Apr 6, 2018

Thanks for the tests, I'll include an expanded version of it in the updated PR #153

@bcl bcl closed this Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clumens clumens clumens approved these changes

@bcl bcl Awaiting requested review from bcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atodorov @coveralls @bcl @clumens