Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware cleanup 2021 #1175

Merged
merged 3 commits into from Oct 7, 2021
Merged

Firmware cleanup 2021 #1175

merged 3 commits into from Oct 7, 2021

Conversation

AdamWill
Copy link
Contributor

@AdamWill AdamWill commented Oct 6, 2021

This PR includes a few commits to drop various probably-unnecessary firmware files in runtime-cleanup, to save about 30M on network install images. This will help with them being oversize for F35 and Rawhide currently.

These firmwares are for Qualcomm smartphone chipsets (SM845 and
SM8250). Don't think they're any use in network install images.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
These add up to 26MB and they are for high-end switches, unlikely
targets for network installs.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@AdamWill
Copy link
Contributor Author

AdamWill commented Oct 6, 2021

@nirik @bcl

@coveralls
Copy link

coveralls commented Oct 6, 2021

Pull Request Test Coverage Report for Build 1313958045

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.612%

Totals Coverage Status
Change from base Build 1305755538: 0.0%
Covered Lines: 1296
Relevant Lines: 2916

💛 - Coveralls

As Peter Robinson explains here:
https://bugzilla.redhat.com/show_bug.cgi?id=2011615#c3
these are not useful, as the devices they're for do not support
netinst-style deployment.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@AdamWill
Copy link
Contributor Author

AdamWill commented Oct 6, 2021

tweaked the last commit to just leave liquidio and netronome firmwares out entirely at install stage; @nullr0ute says to do this in https://bugzilla.redhat.com/show_bug.cgi?id=2011615#c3 .

@nullr0ute
Copy link
Contributor

You can probably drop ipw2100-firmware and ipw2200-firmware as they were only ever sold on i686 machines, and while I'm sure there's someone that has salvaged them and have them in another device I doubt they're using netinst.

@AdamWill
Copy link
Contributor Author

AdamWill commented Oct 7, 2021

thanks. they're pretty tiny, though, they barely add up to a megabyte, so might not be worth bothering with!

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all seem reasonable to me, thanks for including explanations with each, I think it's important to do that since I have no real idea of what firmware blobs are really used and which aren't :)

@bcl bcl merged commit 69c15c9 into weldr:master Oct 7, 2021
@AdamWill
Copy link
Contributor Author

AdamWill commented Oct 7, 2021

Thanks! As I'm intending these changes to help us get the F35 images under size, can you do a new release/build/update for F35? I can just backport the patches if you'd prefer, just let me know :)

@VladimirSlavik
Copy link
Contributor

Thank you!

FYI, I have a private TODO to re-examine the packages on boot.iso. I looked at that a few months ago and there are just so many things that make zero sense at first glance that it's hard to believe. I think the buildup to F34/RHEL9 brought a lot of stuff through some kind of churn. However I didn't check how many of these are cleaned up by the templates.

My idea was to write a script to go through lorax-packages.log, check if the package files are actually present, take stock of what actually remains, then eyeball the data to see if there is anything outright useless. If anyone beats me to it... ;-)

@bcl
Copy link
Contributor

bcl commented Oct 8, 2021

Thanks! As I'm intending these changes to help us get the F35 images under size, can you do a new release/build/update for F35? I can just backport the patches if you'd prefer, just let me know :)

That probably needs a bug and an exception doesn't it? Since we're past the final freeze date.

@bcl
Copy link
Contributor

bcl commented Oct 8, 2021

FYI, I have a private TODO to re-examine the packages on boot.iso. I looked at that a few months ago and there are just so many things that make zero sense at first glance that it's hard to believe. I think the buildup to F34/RHEL9 brought a lot of stuff through some kind of churn. However I didn't check how many of these are cleaned up by the templates.

Inertia is a better description :) I tend to make minimal changes once something has been added since it's hard to know what really depends on it. IIRC the majority of the growth over time has been the firmware blobs but I'm sure there's room for improvement in other areas.

@AdamWill
Copy link
Contributor Author

AdamWill commented Oct 8, 2021

Thanks! As I'm intending these changes to help us get the F35 images under size, can you do a new release/build/update for F35? I can just backport the patches if you'd prefer, just let me know :)

That probably needs a bug and an exception doesn't it? Since we're past the final freeze date.

It has not just one, but two!

  1. https://bugzilla.redhat.com/show_bug.cgi?id=2009730
  2. https://bugzilla.redhat.com/show_bug.cgi?id=2009731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants