Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Malayalam font to its new renamed package name rit-meera-new-fonts #1206

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

pnemade
Copy link
Contributor

@pnemade pnemade commented Jan 17, 2022

I am submitting this PR as part of F36 Change https://fedoraproject.org/wiki/Changes/MalayalamDefaultFontsUpdate

Signed-off-by: Parag Nemade pnemade@fedoraproject.org

…onts

Signed-off-by: Parag Nemade <pnemade@fedoraproject.org>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1706636908

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.538%

Totals Coverage Status
Change from base Build 1689161947: 0.0%
Covered Lines: 1376
Relevant Lines: 2920

💛 - Coveralls

@pnemade
Copy link
Contributor Author

pnemade commented Jan 19, 2022

Can someone please review this PR and merge it?

@bcl
Copy link
Contributor

bcl commented Jan 19, 2022

Is that really the only change needed? I thought that the google-noto-serif-gurmukhi-fonts would also need to be changed to google-noto-serif-gurmukhi-vf-fonts at the least.

@pnemade
Copy link
Contributor Author

pnemade commented Jan 20, 2022

I just want to keep this commit for the Change submitted https://fedoraproject.org/wiki/Changes/MalayalamDefaultFontsUpdate and not to mix it with https://fedoraproject.org/wiki/Changes/DefaultToNotoFonts Change.

I think @tagoh will submit his change to lorax in another PR.

@bcl
Copy link
Contributor

bcl commented Jan 21, 2022

ah! Whoops, I totally missed that this was for a different change proposal :)

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bcl bcl merged commit 2dde5eb into weldr:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants