Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel cmdline customization and ability to run without adding kickstart #1230

Merged
merged 5 commits into from
Jun 6, 2022

Conversation

bcl
Copy link
Contributor

@bcl bcl commented May 26, 2022

No description provided.

@coveralls
Copy link

coveralls commented May 26, 2022

Pull Request Test Coverage Report for Build 2449666660

  • 94 of 113 (83.19%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.9%) to 48.431%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bin/mkksiso 94 113 83.19%
Totals Coverage Status
Change from base Build 2436768296: 3.9%
Covered Lines: 1683
Relevant Lines: 3325

💛 - Coveralls

@bcl bcl force-pushed the master-edit-cmdline branch 3 times, most recently from 642a1c9 to 1d0067d Compare June 3, 2022 17:36
bcl added 5 commits June 6, 2022 11:32
Add some functions to help modify the kernel cmdline, as well as tests
for the new functions.
Also update documentation, and switch to using sphinx-argparse to
generate the cmdline documentation for mkksiso.
Previously you could only add to the kernell cmdline. This updates the
--command arguments to replace existing arguments, and add new ones.

It also adds --rm to remove arguments from the cmdline.

Resolves: rhbz#2037015
This includes test data for cmdline editing tests in tests/mkksiso/data/
Since these are imported as modules in their test directories coverage
can include them in the report.
@bcl bcl merged commit 346b9d7 into weldr:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants