Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport cmdline editing support #1244

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Backport cmdline editing support #1244

merged 4 commits into from
Jun 29, 2022

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Jun 28, 2022

No description provided.

bcl added 4 commits June 28, 2022 14:56
Add some functions to help modify the kernel cmdline, as well as tests
for the new functions.

(cherry picked from commit 9278106)

Related: rhbz#2037015
Also update documentation, and switch to using sphinx-argparse to
generate the cmdline documentation for mkksiso.

(cherry picked from commit 1812ac7)

Related: rhbz#2037015
Previously you could only add to the kernell cmdline. This updates the
--command arguments to replace existing arguments, and add new ones.

It also adds --rm to remove arguments from the cmdline.

Resolves: rhbz#2037015
(cherry picked from commit 6af5c39)
This includes test data for cmdline editing tests in tests/mkksiso/data/

(cherry picked from commit 6155d1d)

Related: rhbz#2037015
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2579485366

  • 94 of 113 (83.19%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.5%) to 43.692%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bin/mkksiso 94 113 83.19%
Totals Coverage Status
Change from base Build 2517191251: 2.5%
Covered Lines: 1497
Relevant Lines: 3202

💛 - Coveralls

@bcl bcl merged commit 8fd7c8c into weldr:rhel9-branch Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants