Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mkksiso on ppc64le #1251

Merged
merged 2 commits into from Jul 22, 2022
Merged

Fix mkksiso on ppc64le #1251

merged 2 commits into from Jul 22, 2022

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Jul 21, 2022

No description provided.

@bcl bcl changed the title Master mkksiso ppc64le Fix mkksiso on ppc64le Jul 21, 2022
@coveralls
Copy link

coveralls commented Jul 21, 2022

Pull Request Test Coverage Report for Build 2714987038

  • 1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 48.176%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bin/mkksiso 1 6 16.67%
Files with Coverage Reduction New Missed Lines %
src/bin/mkksiso 1 67.02%
Totals Coverage Status
Change from base Build 2714572919: -0.08%
Covered Lines: 1687
Relevant Lines: 3349

💛 - Coveralls

Without this the new iso will not boot.

The reason it does not boot is because without the -U it will map
filesnames with '-' in them to '_' and then the CHRP bootloader cannot
find the '\boot\grub\powerpc-ieee1275\' directory on the iso because
it has been renamed to powerpc_ieee1275
@bcl bcl merged commit 894f2f5 into weldr:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants