Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setpriv as ostree containers dependency (#2125655) #1351

Closed
wants to merge 1 commit into from

Conversation

kwozyman
Copy link

@kwozyman kwozyman commented Oct 24, 2023

The rpm-ostree binary requires setpriv binary to be able to deploy containers.

Related to:
https://fedoraproject.org/wiki/Changes/OstreeNativeContainer https://fedoraproject.org/wiki/Changes/OstreeNativeContainerStable

Related: rhbz#2125655
Resolves: https://issues.redhat.com/browse/RHEL-2250

@bcl
Copy link
Contributor

bcl commented Oct 24, 2023

The change itself looks fine, but to make it into RHEL the commit message needs to reference a JIRA issue as Related or Resolves.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6627770666

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.638%

Totals Coverage Status
Change from base Build 3895831634: 0.0%
Covered Lines: 1500
Relevant Lines: 3214

💛 - Coveralls

@kwozyman
Copy link
Author

The change itself looks fine, but to make it into RHEL the commit message needs to reference a JIRA issue as Related or Resolves.

I've added the JIRA issue in the description

@jstodola
Copy link
Contributor

RHEL-2250 is an anaconda issue. This change needs a separate lorax Jira issue.
In addition to that, the change should be also applied to the lorax-templates-rhel package - again with it's own Jira issue.

@bcl
Copy link
Contributor

bcl commented Oct 31, 2023

I've created https://issues.redhat.com/browse/RHEL-15122 for lorax-templates-rhel and https://issues.redhat.com/browse/RHEL-15123 for lorax.

@bcl
Copy link
Contributor

bcl commented Nov 3, 2023

Merged a modified version of this with the correct Jira references, thanks!

@bcl bcl closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants