Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New test: assert toml files in git workspace #838

Merged
merged 2 commits into from Sep 13, 2019
Merged

New test: assert toml files in git workspace #838

merged 2 commits into from Sep 13, 2019

Conversation

atodorov
Copy link
Member

@atodorov atodorov commented Aug 20, 2019 •
edited

Notes:

  • need to test manually before merging

@atodorov atodorov requested a review from bcl August 20, 2019 08:59
@coveralls
Copy link

coveralls commented Aug 20, 2019 •
edited

Pull Request Test Coverage Report for Build 2126

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 2125: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

bcl
bcl approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as on #836

@atodorov atodorov force-pushed the blueprint_delete_test_rhel7 branch 2 times, most recently from ab5a417 to 04b4c0b Compare September 6, 2019 13:10
@atodorov atodorov changed the title New test: assert toml files in git workspace WIP: New test: assert toml files in git workspace Sep 6, 2019
@atodorov
Copy link
Member Author

atodorov commented Sep 6, 2019

Tests report PASS (executed them by hand) but I need approval for
https://bugzilla.redhat.com/show_bug.cgi?id=1749802 before merging.

atodorov and others added 2 commits September 13, 2019 11:28
@atodorov
New test: assert toml files in git workspace
6134b63 
export BLUEPRINTS_DIR for use in tests

Depending on the way the tests are run the directory may be a temporary
dir, or it may be the standard /var/lib/lorax/... path.

Related: rhbz#1749802
@bcl @atodorov
tests: Drop sort from compose types test
eb3302c 
The output from the API is already sorted, and 'sort' changes this
ordering in some situations.

Related: rhbz#1749802
@atodorov atodorov changed the title WIP: New test: assert toml files in git workspace New test: assert toml files in git workspace Sep 13, 2019
@atodorov
Copy link
Member Author

Referenced BZ approved so merging now.

@atodorov atodorov merged commit 9d7fcc8 into weldr:rhel7-extras Sep 13, 2019
@atodorov atodorov deleted the blueprint_delete_test_rhel7 branch September 13, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcl bcl bcl approved these changes

Assignees
No one assigned
Labels
rhel7-extras
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atodorov @coveralls @bcl