Improve lorax-composer disk size estimate #875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2380
💛 - Coveralls |
bcl
changed the title
|
While this does increase the size, according to user reports the amount can vary widely between systems so this still needs work. |
anaconda moves the yum cache to the disk once it is partitioned, so the downloaded rpms also consume space until the installation is finished. Take this into account when estimating the size. Thanks to Christophe Besson for spotting this. Related: rhbz#1761337
Anaconda doesn't download the filelists or 'other' metadata, which can add a significant amount of space to the metadata cache on the build host. So to estimate the amount of space needed by Anaconda exclude the space used by *filelists* and *other* files. With these changes the lorax-composer estimate should actually be fairly accurate. But since Anaconda only uses the installedsize * 1.35 we have to make sure that the size we use is at least as big as what anaconda will estimate, otherwise the installation will fail. Resolves: rhbz#1761337
bcl
force-pushed
the
rhel7-extras-1761337
branch
from
2d7a972
to
ba66985
Compare
bcl
changed the title
|
Figured out why the host metadata and anaconda metadata were so different in size. This should be robust enough to work in all cases. |
|
Merged into rhel7-extras for lorax-19.7.40-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.