-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SerialiSe all the thingz #50
Conversation
I did not touch the version, but of course, that's a PVP-major change. |
@@ -2,7 +2,7 @@ | |||
{-# OPTIONS_GHC -fno-warn-orphans #-} | |||
----------------------------------------------------------------------------- | |||
-- | | |||
-- Module : Data.Binary.Serialize.CBOR | |||
-- Module : Data.Binary.Serialise.CBOR | |||
-- Copyright : 2013 Simon Meier <iridcode@gmail.com>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks odd, because it's the wrong module name all along...
Yeah, note the only real interface change here is in |
https://www.youtube.com/watch?v=Mj2cXQXgyWE&t=43m06s This is clearly the most critical problem in the library. Thanks you @ibotty for addressing it so swiftly. |
We'll have to implement the protective dragon mentioned in #48 later I guess. |
fixes #48.