Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it build with ghc-9.8 and update dependencies #328

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Make it build with ghc-9.8 and update dependencies #328

merged 2 commits into from
Nov 14, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Oct 31, 2023

Main compiler related issue was the absence of a MonadFail Gen instance.

Lot warnings from latest GHC.

@erikd erikd mentioned this pull request Nov 2, 2023
Closed
andreasabel
andreasabel reviewed Nov 12, 2023
View reviewed changes
Copy link
Contributor

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

base < 4.21 is unusual, is this intended? I would have expected base < 4.20.

binary-serialise-cbor/binary-serialise-cbor.cabal Outdated Show resolved Hide resolved
@erikd
Make it build with ghc-9.8 and update dependencies
f910b12 
Main compiler related issue was the absence of a `MonadFail Gen`
instance.
@erikd
CI: Include more recent GHC versions
286de82
@erikd erikd mentioned this pull request Nov 13, 2023
Closed
@bgamari bgamari merged commit 64e2201 into well-typed:master Nov 14, 2023
9 checks passed
bgamari
bgamari reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@bgamari bgamari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploaded:

  • cborg-0.2.10.0
  • binary-serialise-cbor-0.2.2.0-rev2
  • cbor-tool-0.2.2.0-rev5
  • cborg-json-0.2.6.0
  • serialise-0.2.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgamari bgamari bgamari left review comments

@andreasabel andreasabel andreasabel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erikd @bgamari @andreasabel