Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with duplicate header names for custom metadata #97

Closed
edsko opened this issue Feb 29, 2024 · 0 comments · Fixed by #110
Closed

Deal with duplicate header names for custom metadata #97

edsko opened this issue Feb 29, 2024 · 0 comments · Fixed by #110
Labels
priority: medium Should be done before the library can be considered complete spec Part of the spec is not implemented (use bug or enhancement label to distinguish further)

Comments

@edsko
Copy link
Collaborator

edsko commented Feb 29, 2024

The spec requires

Custom-Metadata header order is not guaranteed to be preserved except for values with duplicate header names. Duplicate header names may have their values joined with "," as the delimiter and be considered semantically equivalent. Implementations must split Binary-Headers on "," before decoding the Base64-encoded values.

We do not currently do this.
@edsko edsko added priority: medium Should be done before the library can be considered complete spec Part of the spec is not implemented (use bug or enhancement label to distinguish further) labels Feb 29, 2024
edsko added a commit that referenced this issue Mar 23, 2024
@edsko
Correct treatment of duplicate custom metadata
8ef5ff8 
Closes #97.
@edsko edsko mentioned this issue Mar 23, 2024
Merged
edsko added a commit that referenced this issue Mar 23, 2024
@edsko
Correct treatment of duplicate custom metadata
ee2a8c9 
Closes #97.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium Should be done before the library can be considered complete spec Part of the spec is not implemented (use bug or enhancement label to distinguish further)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct treatment of duplicate custom metadata well-typed/grapesy
1 participant
@edsko