Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Pins required dependencies #17

Closed
wants to merge 2 commits into from
Closed

Pins required dependencies #17

wants to merge 2 commits into from

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented May 9, 2018

In order that clients consuming this library have reliable dependencies we need to pin the required dependencies of this project.

This change introduces fixed versions in setup.py.

@kenoir kenoir requested a review from alexwlchan May 9, 2018 13:02
@alexwlchan
Copy link
Contributor

Close, but I don’t think this is enough. boto3 1.4.5 installs several other packages:

boto3==1.4.5
botocore==1.5.95
docutils==0.14
jmespath==0.9.3
python-dateutil==2.7.2
s3transfer==0.1.13
six==1.11.0

I think we need to pin all of them as well. There are ways to do this, I think, but I’ll need to have another look – pip 10 broke a bunch of APIs here.

Also, this means anybody using our libraries with any other version of boto3 can’t do it. Wouldn’t it be better to pin in the applications?

@kenoir
Copy link
Contributor Author

kenoir commented Jun 4, 2018

Closing as out of date.

@kenoir kenoir closed this Jun 4, 2018
@alexwlchan alexwlchan deleted the pin-requires-versions branch June 4, 2018 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants