Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some concepts are missing from the API #89

Closed
jamieparkinson opened this issue Nov 15, 2022 · 5 comments
Closed

Some concepts are missing from the API #89

jamieparkinson opened this issue Nov 15, 2022 · 5 comments
Assignees

Comments

@jamieparkinson
Copy link
Contributor

No description provided.

@jamieparkinson jamieparkinson self-assigned this Nov 15, 2022
@paul-butcher paul-butcher self-assigned this Nov 22, 2022
@paul-butcher
Copy link
Contributor

paul-butcher commented Nov 23, 2022

The last two things to do to get the missing concepts sorted are:
Point the API to the new catalogue pipeline - this gets rid of the duplicates in Works

wellcomecollection/catalogue-api#586

A day later, run the concepts pipeline to load from the snapshot.

(I think)

@paul-butcher
Copy link
Contributor

There are quite a lot of people that are both Person and Agent. I wonder if that is for the transformer to fix. This needs analysis

@paul-butcher
Copy link
Contributor

This fixes a few from TEI wellcomecollection/catalogue-pipeline#2269

@paul-butcher
Copy link
Contributor

The "Two Glasgows" problem still exists, but it appears that both Glasgows are available from the Concepts API.

A Work both by and about Glasgow (Scotland)
https://wellcomecollection.org/works/uf3jv2sr
Glasgow (Scotland) the Organisation
https://wellcomecollection.org/concepts/v4u8kmxz
Glasgow (Scotland) the Place
https://wellcomecollection.org/concepts/khvx5egx

This is because, as a Place, it is in the namespace lc-subjects, and as an Organisation, it is in the namespace lc-names

However, they are not missing, so this is not so pressing.

@paul-butcher
Copy link
Contributor

People who are both Person and Agent:

Here is an example

Person
https://wellcomecollection.org/concepts/zrm8rsa9
Agent:
https://wellcomecollection.org/concepts/dpume45z

Found in this Work:
https://wellcomecollection.org/works/gf89yyxp

I believe this is caused by this decision, explained here

That the presence of $t means that the person is not a Person. This warrants investigation as to the truth of that assertion. In the case of Maimonides here, n78096039 (the person) is used in both fields - the one with the $t and the one without.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants