Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ADR for GitHub permissions & CODEOWNERS #68

Merged
merged 2 commits into from Sep 8, 2021
Merged

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Sep 7, 2021

Documents the changes from wellcomecollection/platform#5290

Readable version: https://github.com/wellcomecollection/docs/blob/codeowners-perms-adr/adr/github_permissions.md

Describes necessary process for maintaining permissions boundaries in CI.

Copy link
Contributor

@alexwlchan alexwlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@jamesgorrie jamesgorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clear!
Worth having something like this do you think?

https://github.com/wellcomecollection/buildkite-template

Happy to remove it if we think it's overkill, just thought it is easier than remembering and it comes up in the "new repo" UI

Screenshot 2021-09-08 at 12 03 30

@kenoir kenoir merged commit 69a532f into main Sep 8, 2021
@kenoir kenoir deleted the codeowners-perms-adr branch September 8, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants