add skeletal next app sharing code with the rest of the stack #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgorrie
force-pushed
the
next_poc
branch
2 times, most recently
from
f5d0d64
to
8ecf014
Compare
jamesgorrie
commented
Jan 17, 2018
catalogue/webapp/next.config.js
Outdated
| } | ||
| }); | ||
| config.resolve.symlinks = false; | ||
| return config |
|
@jamesgorrie I'm desperate to make it work with |
|
@morgs32 well we use: I haven't had another attempt as this worked, and the mono-repo work I think is on the roadmap for the next.js team. I might have another stab at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #2027
A skeletal
next.jsapp, sharing common code with our stack.I propose that we use this time to tidy up some bits and bobs.
As with this example, we can move the actual shared code into
common, then import it into the concept of filters, which is going to ⚰️. This will then open us up to be able to treat things as functions, and thus test them.@wellcomecollection<= up for changing this, but auto complete help here.There is some work going on in
nextto allow us to make this more streamlined, I've basically replicated the work until it's in a release. See hereI would have liked to have used
yarn's workspaces but because of good ol' node's module resolving this starting becoming tricker than it needed to be.