Add a "concurrency gate" around front-end deployments #9884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwlchan
force-pushed
the
use-concurrency-gate-on-deploys
branch
from
0cd355e
to
c2c6a52
Compare
alexwlchan
commented
Jun 2, 2023
alexwlchan
commented
Jun 2, 2023
rcantin-w
approved these changes
Jun 2, 2023
remove lingering references to stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to wrap my head around this, but I think I get it now.
This implements the "concurrency gate" pattern described in Buildkite's support blog here: https://buildkite.com/blog/concurrency-gates
I'm not going to explain it in the PR description, because there's a comment in the Buildkite YAML and that's the thing we'll have to follow in six months time when we're scratching our heads at this code. If I need to clarify stuff, I'll update that comment rather than this description.
This is an offshoot of the work to get e2es running on pull requests: #9876