Reporting pipeline miro inventory #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting_pipeline_miro_inventory
…n need to json.loads() it in the transform
alexwlchan
approved these changes
Nov 12, 2018
| @@ -50,7 +50,10 @@ def state_reason(self): | |||
|
|
|||
| @property | |||
| def should_be_sent_to_main_channel(self): | |||
| return self.name != "lambda-miro_transformer-errors" | |||
| return self.name not in [ | |||
There was a problem hiding this comment.
nit: always use sets when you’re doing foo in iterable for good performance habits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR trying to achieve?
Adds the miro_inventory pipeline
Who is this change for?
📄📊