VHS dynamo fixes (#138)

* Fix for VHS dynamop

* release

* getting booly

* booling on down to bool town

* there are no stairs in my house

* Apply auto-formatting rules

RELEASE.md

@@ -0,0 +1,3 @@
+RELEASE_TYPE: minor 
+
+Fixes for VHS dynamo module

ecr/repository.tf

@@ -1,7 +1,3 @@
 resource "aws_ecr_repository" "repository" {
   name = "${var.namespace}/${var.id}"
-
-  lifecycle {
-    prevent_destroy = "${var.protected}"
-  }
 }

ecr/variables.tf

@@ -5,8 +5,3 @@ variable "id" {
 variable "namespace" {
   description = "Namespace prefix to ECR repository"
 }
-
-variable "protected" {
-  description = "Protect resource from deletion"
-  default     = true
-}

vhs/modules/dynamo/main.tf

@@ -1,24 +1,13 @@
 resource "aws_dynamodb_table" "table" {
   name             = "${var.table_name_prefix}${var.name}"
-  read_capacity    = 1
-  write_capacity   = 1
   hash_key         = "id"
   stream_enabled   = true
   stream_view_type = "NEW_AND_OLD_IMAGES"
 
-  billing_mode = "${var.billing_mode}"
+  billing_mode = "PAY_PER_REQUEST"
 
   attribute {
     name = "id"
     type = "S"
   }
-
-  lifecycle {
-    prevent_destroy = true
-
-    ignore_changes = [
-      "read_capacity",
-      "write_capacity",
-    ]
-  }
 }

vhs/modules/dynamo/variables.tf

@@ -3,7 +3,3 @@ variable "table_name_prefix" {
 }
 
 variable "name" {}
-
-variable "billing_mode" {
-  description = "Should be either PAY_PER_REQUEST or PROVISIONED"
-}

vhs/modules/vhs/main.tf

@@ -1,17 +1,8 @@
 module "dynamo" {
   source = "../dynamo"
   name   = "${var.name}"
-
-  table_read_max_capacity  = "${var.table_read_max_capacity}"
-  table_write_max_capacity = "${var.table_write_max_capacity}"
-
-  billing_mode = "${var.billing_mode}"
 }
 
 resource "aws_s3_bucket" "bucket" {
   bucket = "${var.bucket_name_prefix}${lower(var.name)}"
-
-  lifecycle {
-    prevent_destroy = true
-  }
 }

vhs/modules/vhs/variables.tf

@@ -3,16 +3,3 @@ variable "name" {}
 variable "bucket_name_prefix" {
   default = "wellcomecollection-vhs-"
 }
-
-variable "table_read_max_capacity" {
-  default = 80
-}
-
-variable "table_write_max_capacity" {
-  default = 300
-}
-
-variable "billing_mode" {
-  default     = "PAY_PER_REQUEST"
-  description = "Should be either PAY_PER_REQUEST or PROVISIONED"
-}