This repository has been archived by the owner on Feb 20, 2020. It is now read-only.

live example not working? #7

Closed

kjpeee opened this issue Feb 26, 2017 · 3 comments · Fixed by #8

kjpeee commented Feb 26, 2017

timeline not working
https://wellcomelibrary.org/collections/digital-collections/makers-of-modern-genetics/genetics-timeline/
shows empty page (only header and footer of the page)

Contributor

tomcrane commented Feb 26, 2017

Hi @prioritylabs
Thanks for the info. The problem is here - https://github.com/wellcometrust/timeline/blob/master/src/js/embed.js#L153

Need to consider protocol as well as other link props.

It works over http:
http://wellcomelibrary.org/collections/digital-collections/makers-of-modern-genetics/genetics-timeline/

I will fix this. Thanks!

tomcrane mentioned this issue

embed script detects protocol #8

Merged

Contributor

tomcrane commented Feb 26, 2017

Hi @jennpb - seeing as this is now a wellcometrust repo, I didn't accept my own pull request (#8). I have deployed the fix to wellcomelibrary.org though, as https://github.com/wellcomelibrary/dds-ecosystem/pull/23.

Contributor

tomcrane commented Feb 26, 2017

@edsilv FYI - fixed in #8

jennpb closed this as completed in #8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.