Update PR template #388
Merged
Update PR template #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwlchan
reviewed
Feb 2, 2017
PULL_REQUEST_TEMPLATE.md
Outdated
| - [ ] Tests? | ||
| - [ ] Docs? | ||
| - [ ] Have you had a conversation with the right people about the implications of this feature? |
There was a problem hiding this comment.
I’d suggest the less formal version from the PR description:
Have you spoken to the right people about the implications of this feature?
Or, given that the other items are all short reminders, not full checklist items, maybe just:
Spoken to the right people?
gestchild
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR trying to achieve?
Adding a question to the PR template (have you spoken to the right people?).