Add delegate parameter to allow for harvesting additional data from react element #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent and add it to ownerDataMap.
|
@vzaidman, I would appreciate review of this proposed change when you have a moment. Please let me know if you have any questions or concerns.
|
|
Hey! |
I think this will be a little more appropriate and clear what's WDYR native, and what was added to `ownerDataMap` by the user.
|
Thank you very much for your contribution! Sorry it took me so long to approve. Notice the little change I did in the code. |
|
published in v6.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to expose the _nativeTag on the element, I need access to the raw react element, most easily accessed in the 'storeOwnerData' function. Created an optional delegate parameter to access the raw element and return additional data in a returned object, which is stored in the ownerDataMap to be referenced later.
With this change, in combination with my 'notifier' override adding this data to the 'displayName', I am able to identify my native elements via their closest relative native Id (which can be used to correlate wdyr to my ReactNative UI elements).