Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling too many buttons for two button rows #283

Closed
PietKnot opened this issue Jun 22, 2023 · 11 comments
Closed

handling too many buttons for two button rows #283

PietKnot opened this issue Jun 22, 2023 · 11 comments

Comments

@PietKnot
Copy link

reporting now a very small issue: when too many buttons are to be displayed in 2 widget rows in landscape mode, it would be nice to have a third row:

Screenshot_20230622-214022

There are actually 11 buttons displayed in portrait mode, but in landscape mode only 10 are visible and the Back button missing. I know that i could reduce the button size but they are actually already small (on 4 inch screen), thus maybe it's easy to implement, but don't bother too much about it.

@wellenvogel
Copy link
Owner

OK, also reproduced...
The button auto resizing does not work any more.
In this situation the buttons should be reduced in size.

@PietKnot
Copy link
Author

works almost: the buttons are resized (now 6 in one columN), but the MOB-button is "lost", e.g. not displayed anymore; it was the tenth button of the 11 in portrait mode; There is space left is the second column

@wellenvogel
Copy link
Owner

That would be strange. Are you sure that you have a valid position? Otherwise no MOB button at all...

@PietKnot
Copy link
Author

Yes; rather sure. Just made the verification at home again with internal GPS on Android phone.

Portrait mode: 11 buttons including MOB and active position
Screenshot_20230629-212719

Lanscape mode: MOB missing; made at the same time after the above one.
Screenshot_20230629-212733

@free-x
Copy link
Contributor

free-x commented Jun 30, 2023

Hi,

i can't confirm this behavior with my FHD/FHD+ gadgets.
Which resolution of screen do you have?

Regardings
free-x

@wellenvogel
Copy link
Owner

I cannot reproduce this on my side too.
Which device are you using? Looks like a rather old android device.
Do you use the native android app? BonjourBrowser? Browser?

Any way the "reduce size" handling is more like a "last resort" if you accidently set the button size too big.
So if this hits only some rather old device I would not invest too much on it. Maybe the browser does not trigger some resize - or it reports wrong dimensions...

Could you cross check if the button will become visible if you leave the page and go back?

@wellenvogel
Copy link
Owner

Ok, inverstigated a bit further:
I was able to reproduce some similar situations and made an additional correction.
A daily build is on the way - maybe you could retest using the one from today.

@PietKnot
Copy link
Author

PietKnot commented Jul 2, 2023

i will do further tests bij reducing the button-size to see if the MOB-button was possibly the 7th button on the right column with 6 buttons (just for test as the buttons will become physically too small).

But first the requested info on the Android. it's not a rather old Android device (actually a Cubot mini KingKong 2) running Android 10 with graphical spec:

4.00 inch, 18:9, 450 cd/m2
1080 x 540 pixel 302 PPI,
kapazitiver Touchscreen, IPS,
glimmend: ja, 60 Hz

Update: problem found: the button-size defined in the settings was 50 resulting in loosing one button on the display. Reducing the button size to 40, 6,5 buttons are shown (0,5 button = part of the MOB-button that was missing). Further reducing the button size to 38 and all is fine.
Screenshot_20230702-234819

Thus my conclusion is the that auto-resizing logic is not optimal for this specific screen, and no buttons are really lost, but just not visible. With 6 buttons in one colomn it should perfectly be possible to display the 12 buttons with auto-resizing.

Verification done on V20230628 native app without external browser.

@wellenvogel
Copy link
Owner

Ok, hopefully the daily (and the new release) should fix the issue.

@wellenvogel
Copy link
Owner

release 20230702

@PietKnot
Copy link
Author

PietKnot commented Jul 3, 2023

Excellent, well done; all buttons are visible now with 7 buttons in one column (although 6 buttons would work as well see above). Thanks for the "last resort" functionality that allows for larger buttons in portrait mode and smaller in landscape mode.

P.s. a button-size settting for landscape-mode would have done it as well and maybe easier to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants