Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for Notifications #16

Merged
merged 31 commits into from
Jul 30, 2020
Merged

Create tests for Notifications #16

merged 31 commits into from
Jul 30, 2020

Conversation

hesyifei
Copy link
Member

A part of #11.

  • Create tests for Notifications (helpers/notifications.ts).
  • Add frequency.expireAfterMinutes instead of hard-coding 2 hours expiration time.

…cationAsync inside describe "setNotificationsAsync"
@hesyifei hesyifei self-assigned this Jul 30, 2020
@hesyifei hesyifei merged commit 382cb7e into master Jul 30, 2020
@hesyifei hesyifei deleted the notifications-test branch August 1, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant