Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Study file schema with Zod #17

Merged
merged 60 commits into from
Aug 1, 2020
Merged

Study file schema with Zod #17

merged 60 commits into from
Aug 1, 2020

Conversation

hesyifei
Copy link
Member

@hesyifei hesyifei commented Jul 31, 2020 •
edited
Loading

  • Created schemas for the study file (including questions, streams, etc.) with Zod.
  • Added more documentation for fields in the study info.
  • Added tests for all questions schemas (excluding BranchQuestionSchema and BranchWithRelativeComparisonQuestionSchema).

Part of #3 and #11.

@hesyifei
Install zod
97a5e79
@hesyifei
Merge branch 'master' into json-zod
44f6f85
@hesyifei
Basic types and docs for StudyFile schema
012e857
@hesyifei
Some QuestionSchema support
c2e21c4
@hesyifei
Minor changes
6846ac9
@hesyifei
Better refinements
2d3f3a5
@hesyifei
Add todo
bdd0571
@hesyifei
Move some schema to Question.ts
18c3a8c
@hesyifei
Minor change
a56c802
@hesyifei
Add more question schemas
5146f27
@hesyifei
Move some schemas to Stream.ts
ea240b0
@hesyifei
Add more question scheams
603b017
@hesyifei
Finish adding question schema
4d9919d
@hesyifei
Update HomeScreen.tsx
9da530c
@hesyifei
Add QuestionTypeType & Rename SurveyFile to StudyFile
bf67404
@hesyifei
Update pings.ts
3f6ca4e
@hesyifei
Update SurveyScreen.tsx
73d4f9d
@hesyifei
Remove old code in types.ts
55b6745
@hesyifei
Use parseJsonToStudyFile in getSurveyFileAsync
0e23ca5
@hesyifei
Create common.ts to avoid circular dependency
3cacf73
@hesyifei
Better QuestionSchema
fce1ed4
@hesyifei
Add test for QuestionIdSchema
b268bea
@hesyifei
Create QuestionIdSchemaNullable
e6d2b1c
@hesyifei
Create more generalized CustomNullable
704f6cd
@hesyifei
Add comments
bfe8abb
@hesyifei
Add some tests for QuestionSchema
17e4327
@hesyifei
Ad tests for SliderQuestionSchema
6d69458
@hesyifei
Add test for QuestionTypeSchema
3c59eaa
@hesyifei hesyifei added the enhancement New feature or request label Jul 31, 2020
@hesyifei hesyifei self-assigned this Jul 31, 2020
@hesyifei
ChoicesQuestionSchema randomizeChoicesOrder test
e3b37a7
@hesyifei
ChoicesQuestionSchema randomizeExceptForChoiceIds test
70514af
@hesyifei
ChoicesWithSingleAnswerQuestionSchema & ChoicesWithMultipleAnswersQue…
48b12e0 
…stionSchema test
@hesyifei
Moving Question schemas test to separate files
c482b9e
@hesyifei
Add todo for specialCasesStartId
c2f776e 
Waiting for colinhacks/zod#104
@hesyifei
YesNoQuestionSchema partial test
2256189
@hesyifei
YesNoQuestionSchema test
10bccfb
@hesyifei
MultipleTextQuestionSchema type test
9eba4bd
@hesyifei
MultipleTextQuestionSchema indexName test
be07a95
@hesyifei
MultipleTextQuestionSchema variableName test
6b698a0
@hesyifei
MultipleTextQuestionSchema eachId test
b057c3b
@hesyifei
Remove eachId for MultipleTextQuestionSchema
6faba84 
and use an array instead of a object to store the results
@hesyifei
Update survey.json
cac86a8
@hesyifei
MultipleTextQuestionSchema placeholder test
0180a8b
@hesyifei
MultipleTextQuestionSchema choices test
b036aa8
@hesyifei
MultipleTextQuestionSchema forceChoice test
37ab033
@hesyifei
MultipleTextQuestionSchema max test
050097f
@hesyifei
MultipleTextQuestionSchema maxMinus test
7c25869
@hesyifei
MultipleTextQuestionSchema repeatedItemStartId test
b1745e6
@hesyifei
MultipleTextQuestionSchema fallbackItemStartId test
4c3fada
@hesyifei
HowLongAgoQuestionSchema test
c416612
@hesyifei
QuestionSchema id should not be empty
95563bb
@hesyifei
QuestionsListSchema test
a819cde
@hesyifei
QuestionsListSchema should not accept non-existent next
db7d674
@hesyifei
QuestionsListSchema should show individual question error
6eb364b
@hesyifei
Update StudyFile.ts
10517ce
@hesyifei hesyifei marked this pull request as ready for review August 1, 2020 01:52
@hesyifei hesyifei merged commit 4344511 into master Aug 1, 2020
@hesyifei hesyifei deleted the json-zod branch August 1, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hesyifei hesyifei

Labels
enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hesyifei