-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup StudyScreen
#28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But it is still quite messy 😕
…xt logic in `SurveyScreen`
This is to avoid the getCurrentStudyInfoAsync = null error.
…each question is loaded
As it breaks the type inference (it will set the type to `any`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SurveyScreen
(especially in theonNextSelect
function) to make it clearer.StudyScreen
.StudyScreen
to make it clearer.StudyScreen
'scurrentQuestionId
state andextraMetaData
state intocurrentQuestionData
state to make it easier for stacking future question ID and data.addAnswerToAnswersListAsync
inSurveyScreen
toinsertAnswerAsync
in theanswers
helper file.isInTransition
state inSurveyScreen
that would make the screen blank before each question is loadedQuestionIdSchema
allow[
and]
so that the variable placeholders can be used properly.MultipleTextQuestionSchema
'sindexName
andvariableName
be question ID-compatible as they might be used in question ID.fallbackNext
toBaseQuestionSchema
"_pna"
inspecialCasesStartId
fromChoicesQuestionSchema
.fallbackItemStartId
fromMultipleTextQuestionSchema
.specialCasesStartId
inChoicesQuestionSchema
ChoicesWithMultipleAnswers
.For tests:
StudyScreen
.waitFor
. Fix some problems withact
.Part of #11.