Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Windows, Bun & Deno): startService doesn't ends #118

Merged
merged 22 commits into from
Mar 24, 2024
Merged

Conversation

wellwelwel
Copy link
Owner

@wellwelwel wellwelwel commented Mar 17, 2024

Also fixes partially (Windows):

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.82%. Comparing base (d224bbd) to head (95e1d14).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   81.39%   84.82%   +3.42%     
==========================================
  Files          28       27       -1     
  Lines        1489     1964     +475     
  Branches        0      178     +178     
==========================================
+ Hits         1212     1666     +454     
- Misses        277      290      +13     
- Partials        0        8       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel marked this pull request as draft March 17, 2024 10:05
@wellwelwel wellwelwel changed the title fix(Bun & Deno): startService doesn't ends fix(Windows, Bun & Deno): startService doesn't ends Mar 17, 2024
@wellwelwel wellwelwel marked this pull request as ready for review March 24, 2024 03:05
@wellwelwel wellwelwel merged commit 2dd7fe0 into main Mar 24, 2024
28 checks passed
@wellwelwel wellwelwel deleted the fix-service-end branch March 24, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant