-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace loadable-content
with react-loadable
#198
Conversation
@MortezaT Thank you for this PR. There're some async components seems not be replaced by |
@wellyshen |
@MortezaT Thank you for doing this change. I'm reviewing this PR. I found there's an error from the console log of Google Chrome as following. Can you help to fix it? |
@wellyshen that's a react 16 issue which interprets white spaces as difference between If you run it in |
@MortezaT Thank you for sharing this issue. I remember that I didn't choice |
@wellyshen @MortezaT I'm looking into this error, here seems to be the chronology of the error:
So after 1. the DOM contains the User List I'm not familiar enough with react-loadable yet to understand if this is normal behaviour, I can't understand how the server and client DOM will match if the component needs to be loaded in the client before displaying the data (as this will always require a Loading... I'll continue investigating and update you later. |
@Rid Thank you for your time. |
@all-contributors please add @MortezaT for code |
I've put up a pull request to add @MortezaT! 🎉 |
fixes #197