refactor: rename loadMoreThreshold option to loadMoreCount

wellyshen · Jun 1, 2021 · 3c55e86 · 3c55e86
1 parent 918085f
commit 3c55e86
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/.changeset/quiet-poems-begin.md b/.changeset/quiet-poems-begin.md
@@ -0,0 +1,5 @@
+---
+"react-cool-virtual": patch
+---
+
+refactor: rename `loadMoreThreshold` option to `loadMoreCount`
diff --git a/src/types/index.ts b/src/types/index.ts
@@ -93,7 +93,7 @@ export interface Options {
   useIsScrolling?: UseIsScrolling;
   scrollDuration?: number;
   scrollEasingFunction?: ScrollEasingFunction;
-  loadMoreThreshold?: number;
+  loadMoreCount?: number;
   isItemLoaded?: IsItemLoaded;
   loadMore?: LoadMore;
   onScroll?: OnScroll;

diff --git a/src/types/react-cool-virtual.d.ts b/src/types/react-cool-virtual.d.ts
@@ -103,7 +103,7 @@ declare module "react-cool-virtual" {
     useIsScrolling?: UseIsScrolling;
     scrollDuration?: number;
     scrollEasingFunction?: ScrollEasingFunction;
-    loadMoreThreshold?: number;
+    loadMoreCount?: number;
     isItemLoaded?: IsItemLoaded;
     loadMore?: LoadMore;
     onScroll?: OnScroll;

diff --git a/src/useVirtual.ts b/src/useVirtual.ts
@@ -61,7 +61,7 @@ export default <
   useIsScrolling,
   scrollDuration = 500,
   scrollEasingFunction = easeInOutCubic,
-  loadMoreThreshold = 15,
+  loadMoreCount = 15,
   isItemLoaded,
   loadMore,
   onScroll,
@@ -303,7 +303,7 @@ export default <
       )
         loadMoreRef.current({
           startIndex: 0,
-          stopIndex: loadMoreThreshold - 1,
+          stopIndex: loadMoreCount - 1,
           loadIndex: 0,
           scrollOffset,
           userScroll: userScrollRef.current,
@@ -388,8 +388,8 @@ export default <
           userScroll: userScrollRef.current,
         });
 
-      const loadIndex = Math.floor((vStop + 1) / loadMoreThreshold);
-      const startIndex = loadIndex * loadMoreThreshold;
+      const loadIndex = Math.floor((vStop + 1) / loadMoreCount);
+      const startIndex = loadIndex * loadMoreCount;
 
       if (
         loadMoreRef.current &&
@@ -398,7 +398,7 @@ export default <
       )
         loadMoreRef.current({
           startIndex,
-          stopIndex: startIndex + loadMoreThreshold - 1,
+          stopIndex: startIndex + loadMoreCount - 1,
           loadIndex,
           scrollOffset,
           userScroll: userScrollRef.current,
@@ -413,8 +413,8 @@ export default <
       getCalcData,
       getMeasure,
       itemCount,
+      loadMoreCount,
       loadMoreRef,
-      loadMoreThreshold,
       marginKey,
       onScrollRef,
       resetIsScrolling,